Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cannot read property 'map' of undefined #7

Closed
warpdesign opened this issue Jun 5, 2020 · 3 comments
Closed

Cannot read property 'map' of undefined #7

warpdesign opened this issue Jun 5, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@warpdesign
Copy link

I opened VSCode in a WSL directory, then right clicked on a folder and chose "Open in Windows Terminal" and got this error:

Could not launch Windows Terminal: Cannot read property 'map' of undefined

  • VSCode version 1.45.1
  • Ubuntu-20.04 on WSL 2
  • Windows Terminal 1.0.1401.0
@Tyriar Tyriar added the bug Something isn't working label Jun 5, 2020
@Tyriar
Copy link
Owner

Tyriar commented Jun 5, 2020

@warpdesign are you using the preview and didn't have stable installed? This might be #6

@warpdesign
Copy link
Author

warpdesign commented Jun 6, 2020

I'm using the stable build.

Looking at the extension code it seems it expects a list array with the profiles in the terminal json settings file:

const defaultProfile = settings.profiles.list.find(p => p.guid === settings.defaultProfile)

Problem is in my settings file, profiles is the array containing the profiles:

{
profiles: [
...

There is no profiles.list property.

I guess this explains the crash.

@Tyriar
Copy link
Owner

Tyriar commented Jun 6, 2020

I guess the schema changed at one point, can add support for both 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants