Skip to content

Commit fc46534

Browse files
authored
Pass --no-dds to some integration tests driven by flutter drive (flutter#152898)
As in flutter#152696, It's not clear that DDS initialization is necessary for any of these tests. In particular, from the comments on the tool flag: ``` 'It may be necessary to disable this when attaching to an application with ' 'an existing DDS instance (e.g., attaching to an application currently ' 'connected to by "flutter run"), or when running certain tests.\n' 'Disabling this feature may degrade IDE functionality if a DDS instance is ' 'not already connected to the target application.' ``` These tests are unlikely to need IDE functionality. I have initially modified the Linux_android_emu tests in the ci.yaml so that they run in presubmit to verify that this change is safe. Many other postsubmit-only tests that will now be passed `--no-dds` require physical devices, and if there is an issue in post-submit, this change will need to be reverted.
1 parent 3612ba1 commit fc46534

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

dev/devicelab/lib/framework/utils.dart

+4
Original file line numberDiff line numberDiff line change
@@ -478,6 +478,10 @@ List<String> _flutterCommandArgs(String command, List<String> options) {
478478
'5',
479479
],
480480

481+
// DDS should be disabled for flutter drive in CI.
482+
// See https://github.com/flutter/flutter/issues/152684.
483+
if (command == 'drive') '--no-dds',
484+
481485
if (command == 'drive' && hostAgent.dumpDirectory != null) ...<String>[
482486
'--screenshot',
483487
hostAgent.dumpDirectory!.path,

dev/devicelab/lib/tasks/gallery.dart

-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ class GalleryTransitionTest {
134134
: '${testFile}_test');
135135
section('DRIVE START');
136136
await flutter('drive', options: <String>[
137-
'--no-dds',
138137
'--profile',
139138
if (enableImpeller != null && enableImpeller!) '--enable-impeller',
140139
if (enableImpeller != null && !enableImpeller!) '--no-enable-impeller',

dev/devicelab/lib/tasks/perf_tests.dart

-1
Original file line numberDiff line numberDiff line change
@@ -1395,7 +1395,6 @@ class PerfTest {
13951395
'--local-engine-src-path',
13961396
localEngineSrcPath
13971397
],
1398-
'--no-dds',
13991398
'--no-android-gradle-daemon',
14001399
'-v',
14011400
'--verbose-system-logs',

0 commit comments

Comments
 (0)