fix: add hyphen to password regexes

UN-OCHA · Sep 28, 2021 · 1c3d8b6 · 1c3d8b6
1 parent 98034aa
commit 1c3d8b6
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/api/models/User.js b/api/models/User.js
@@ -350,7 +350,7 @@ UserSchema.statics = {
    */
   isStrongPassword(password) {
     // eslint-disable-next-line no-useless-escape
-    const regex = /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*()+=\\`{}[\]:";'< >?,.\/]).+$/;
+    const regex = /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*()+=\\`{}[\]:";'< >?,.\/-]).+$/;
     return password.length >= 12 && regex.test(password);
   },
 

diff --git a/assets/js/passwords.js b/assets/js/passwords.js
@@ -21,7 +21,7 @@
    */
   function checkPassword(password) {
     // eslint-disable-next-line no-useless-escape
-    var passwordStrength = /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*()+=\\`{}[\]:";'< >?,.\/]).+$/;
+    var passwordStrength = /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*()+=\\`{}[\]:";'< >?,.\/-]).+$/;
     return password.length >= 12 && passwordStrength.test(password);
   }
 

diff --git a/templates/includes/password-regex.html b/templates/includes/password-regex.html
@@ -1 +1 @@
-^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&amp;*()+=\\`{}[\]:&quot;;'&lt; &gt;?,.\/]).+$
+^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&amp;*()+=\\`{}[\]:&quot;;'&lt; &gt;?,.\/-]).+$
diff --git a/templates/includes/password-requirements.html b/templates/includes/password-requirements.html
@@ -8,7 +8,7 @@
       <li>One number <code>0123456789</code></li>
       <li>One uppercase character <code>ABCDEFGHIJKLMNOPQRSTUVWXYZ</code></li>
       <li>One lowercase character <code>abcdefghijklmnopqrstuvwxyz</code></li>
-      <li>One special character <code>!@#$%^&amp;*()+=\`{}[]:";'&lt; &gt;?,./</code></li>
+      <li>One special character <code>!@#$%^&amp;*()+=\`{}[]:";'&lt; &gt;?,./-</code></li>
     </ul>
   </li>
   <li>Not be based on a simple word or pattern.</li>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		^(?=.[a-z])(?=.[A-Z])(?=.\d)(?=.[!@#$%^&*()+=\\`{}[\]:";'< >?,.\/]).+$
		^(?=.[a-z])(?=.[A-Z])(?=.\d)(?=.[!@#$%^&*()+=\\`{}[\]:";'< >?,.\/-]).+$