Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

baseURL vs baseUrl #20

Closed
bmuenzenmeyer opened this issue Jan 25, 2024 · 1 comment · Fixed by #21
Closed

baseURL vs baseUrl #20

bmuenzenmeyer opened this issue Jan 25, 2024 · 1 comment · Fixed by #21

Comments

@bmuenzenmeyer
Copy link

bmuenzenmeyer commented Jan 25, 2024 •
edited
Loading

This library is exactly what I was looking for, thanks so far!

I'm having trouble using baseUrl in the config.

Docs: baseUrl https://github.com/UmbrellaDocs/linkspector?tab=readme-ov-file#base-url
Config Validator: baseUrl https://github.com/UmbrellaDocs/linkspector/blob/main/lib/validate-config.js#L25
Usage: baseURL destructured off of config -

linkspector/lib/extract-markdown-hyperlinks.js

Line 39 in 43c2afb

if (baseURL && url.startsWith('/')) {

I think this mismatch is making it never be applied, right?
@gaurav-nelson gaurav-nelson mentioned this issue Jan 26, 2024
Merged
@gaurav-nelson
Copy link
Contributor

@bmuenzenmeyer Thank you for creating a detailed issue. I've pushed a fix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix baseUrl variable name UmbrellaDocs/linkspector
2 participants
@bmuenzenmeyer @gaurav-nelson