Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] When checking markdown file some links have trailing period #96

Closed
theskillwithin opened this issue Dec 11, 2024 · 3 comments · May be fixed by #95
Closed

[BUG] When checking markdown file some links have trailing period #96

theskillwithin opened this issue Dec 11, 2024 · 3 comments · May be fixed by #95
Labels
invalid This doesn't seem right question Further information is requested

Comments

@theskillwithin
Copy link

When checking markdown files. get a lot of links with a trailing period when the check runs on them. however this trailing period does not exist in the markdown file itself

simple solution could be just to remove any trailing periods from the url string before testing

  message:"Cannot reach https://www.jogc.com/article/S1701-2163(16)39372-0/fulltext. Status: 403"  location:{path:"docs/resources/ailment_resources_links.md"  range:{start:{line:141  column:3}  end:{line:141  column:104}}}  severity:ERROR  source:{name:"linkspector"  url:"https://github.com/UmbrellaDocs/linkspector"}
  message:"Cannot reach https://www.cag-acg.org/images/publications/GERD_Consensus_Update_2004.pdf. Status: 404"  location:{path:"docs/resources/ailment_resources_links.md"  range:{start:{line:157  column:3}  end:{line:157  column:101}}}  severity:ERROR  source:{name:"linkspector"  url:"https://github.com/UmbrellaDocs/linkspector"}
  message:"Cannot reach https://www.pharmacists.ca/cpha-ca/assets/File/minorailments/GERD_En_FINAL.pdf. Status: 403"  location:{path:"docs/resources/ailment_resources_links.md"  range:{start:{line:161  column:3}  end:{line:161  column:96}}}  severity:ERROR  source:{name:"linkspector"  url:"https://github.com/UmbrellaDocs/linkspector"}

To Reproduce
Steps to reproduce the behavior:

Run through a markdown file with a lot of links

- [SOGC on Emergency Contraception (2015)](https://www.jogc.com/article/S1701-2163(16)39372-0/fulltext)
@theskillwithin theskillwithin added the bug Something isn't working label Dec 11, 2024
@theskillwithin theskillwithin mentioned this issue Dec 11, 2024
Open
10 tasks
@gaurav-nelson
Copy link
Contributor

Thank you @theskillwithin for creating this issue. I was unable to reproduce this issue. Can you share a file or failed run if you have run it in an action?

@gaurav-nelson gaurav-nelson added the question Further information is requested label Dec 12, 2024
@theskillwithin

This comment was marked as resolved.

# to view
@gaurav-nelson
Copy link
Contributor

Well that . is not the part of the failed link but the message Linkspector shows.

If you check the status it shows 403 which means server did not process the request. Which is common when using the GitHub action because they don't want too many bots to block the traffic.

@gaurav-nelson gaurav-nelson added invalid This doesn't seem right and removed bug Something isn't working labels Dec 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Milestone
No milestone
2 participants
@theskillwithin @gaurav-nelson