From 2e4fdc0fde3b3d1e757a8e88c79313d9c16f7d95 Mon Sep 17 00:00:00 2001
From: Sean Arms <67096+lesserwhirls@users.noreply.github.com>
Date: Thu, 16 Jan 2025 12:06:06 -0700
Subject: [PATCH] Address a few codeql reports
---
.../catalogservice/RemoteCatalogServiceController.java | 2 +-
tds/src/main/webapp/WEB-INF/templates/gridFragments.html | 8 ++++++--
tds/src/main/webapp/WEB-INF/templates/pointFragments.html | 8 ++++++--
3 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/tds/src/main/java/thredds/server/catalogservice/RemoteCatalogServiceController.java b/tds/src/main/java/thredds/server/catalogservice/RemoteCatalogServiceController.java
index a1b28b0de2..7da451d5ac 100644
--- a/tds/src/main/java/thredds/server/catalogservice/RemoteCatalogServiceController.java
+++ b/tds/src/main/java/thredds/server/catalogservice/RemoteCatalogServiceController.java
@@ -81,7 +81,7 @@ protected ModelAndView handleRequest(HttpServletRequest request, HttpServletResp
Formatter f = new Formatter();
f.format("Error reading catalog '%s' err=%s%n", uri, builder.getErrorMessage());
if (!uri.toString().toLowerCase(Locale.ROOT).endsWith(".xml")) {
- f.format("Expected catalog uri = '" + uri + "' to end with '.xml'");
+ f.format("Expected catalog uri = '%s' to end with '.xml'", uri);
}
log.debug(f.toString());
response.sendError(HttpServletResponse.SC_BAD_REQUEST, f.toString());
diff --git a/tds/src/main/webapp/WEB-INF/templates/gridFragments.html b/tds/src/main/webapp/WEB-INF/templates/gridFragments.html
index 1846f511a5..156b01df3a 100644
--- a/tds/src/main/webapp/WEB-INF/templates/gridFragments.html
+++ b/tds/src/main/webapp/WEB-INF/templates/gridFragments.html
@@ -18,10 +18,14 @@
-
+
-
+
+
-
+