Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ObservableCursor aliases all lists it passes to callbacks #244

Open
domq opened this issue Nov 7, 2019 · 0 comments · May be fixed by #245
Open

ObservableCursor aliases all lists it passes to callbacks #244

domq opened this issue Nov 7, 2019 · 0 comments · May be fixed by #245

Comments

@domq
Copy link

domq commented Nov 7, 2019

There is only one _this._data array per ObservableCursor, that gets passed around by reference to all _observers every time _handleChange runs. As a result, downstream consumers that try to filter out null changes (such as Angular's | async pipe, which relies on WrappedValue) get confused, as they compare old and new values by keeping a reference to the old one.

#100 might be a symptom of the same cause.

domq pushed a commit to epfl-fsd/meteor-rxjs that referenced this issue Nov 7, 2019
@domq domq linked a pull request Nov 7, 2019 that will close this issue
domq pushed a commit to epfl-fsd/meteor-rxjs that referenced this issue Nov 7, 2019
domq pushed a commit to epfl-fsd/meteor-rxjs that referenced this issue Nov 18, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant