Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vehicle ids not parsed as uint64_t #228

Closed
jcoupey opened this issue May 6, 2019 · 0 comments · Fixed by #229
Closed

Vehicle ids not parsed as uint64_t #228

jcoupey opened this issue May 6, 2019 · 0 comments · Fixed by #229
Milestone

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented May 6, 2019

Vehicle ids have vroom::Idtype, aka uint64_t. But in input_parser.cpp, they are parsed with rapidjson's GetUint here:

auto v_id = json_vehicle["id"].GetUint();

and here:
Vehicle current_v(json_vehicle["id"].GetUint(),

We should get them using GetUint64 just like job ids.

@jcoupey jcoupey added this to the v1.5.0 milestone May 6, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant