Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Includes cleanup #425

Closed
jcoupey opened this issue Jan 4, 2021 · 1 comment · Fixed by #426
Closed

Includes cleanup #425

jcoupey opened this issue Jan 4, 2021 · 1 comment · Fixed by #426

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Jan 4, 2021

I came across this blog post https://www.fluentcpp.com/2021/01/01/include-what-you-use/ and it would be interesting to see how include-what-you-use performs on the codebase.

@jcoupey jcoupey added this to the v1.9.0 milestone Jan 4, 2021
@jcoupey jcoupey mentioned this issue Jan 5, 2021
5 tasks
@jcoupey
Copy link
Collaborator Author

jcoupey commented Jan 5, 2021

First impression is: there are a lot of false positives: includes suggested for removal that are mandatory, sometimes in an obvious manner.

But so far, simply applying the good suggestions allowed me to remove 108 includes (!!). The single-threaded build time (time make -j 1) goes down from 1m20 to 0m54, which means a cut of a third of the compile time.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant