Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Longitude, Latitude order in Coordinates is not obvious #730

Closed
kkarbowiak opened this issue Jun 21, 2022 · 1 comment
Closed

Longitude, Latitude order in Coordinates is not obvious #730

kkarbowiak opened this issue Jun 21, 2022 · 1 comment

Comments

@kkarbowiak
Copy link
Contributor

Coordinates is defined as std::array<Coordinate, 2>, which does not inform on the order of the coordinate pair. Is it (Lat, Lon) or (Lon, Lat)? At first I made a mistake and provided the coordinates in incorrect order.

The situation could be improved by adding e.g. an enum: enum { LON_INDEX = 0, LAT_INDEX = 1};, or better yet, by defining coordinates as a struct with named members.

@jcoupey jcoupey added this to the v1.13.0 milestone Jun 23, 2022
@jcoupey
Copy link
Collaborator

jcoupey commented Jun 23, 2022

Landed with #731.

@jcoupey jcoupey closed this as completed Jun 23, 2022
@jcoupey jcoupey added C++ API and removed API labels Jun 23, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants