Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missing exception in HttpWrapper::ssl_send_then_receive #770

Closed
jcoupey opened this issue Aug 29, 2022 · 1 comment
Closed

Missing exception in HttpWrapper::ssl_send_then_receive #770

jcoupey opened this issue Aug 29, 2022 · 1 comment
Labels
enhancement routing
Milestone
v1.13.0

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Aug 29, 2022

Back in #477, we switched from assert to exceptions for errors in HttpWrapper::send_then_receive but then the same changes should have been applied to similar asserts in HttpWrapper::ssl_send_then_receive.
@jcoupey jcoupey added this to the v1.13.0 milestone Aug 29, 2022
@jcoupey jcoupey mentioned this issue Aug 29, 2022
Merged
3 tasks
@jcoupey
Copy link
Collaborator Author

jcoupey commented Aug 30, 2022

Done in #765.

@jcoupey jcoupey closed this as completed Aug 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement routing
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
1 participant
@jcoupey