Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vshops edit #117

Open
sfxworks opened this issue Sep 3, 2018 · 6 comments
Open

Vshops edit #117

sfxworks opened this issue Sep 3, 2018 · 6 comments
Assignees
Labels
bug Things that don't work the way they should

Comments

@sfxworks
Copy link

sfxworks commented Sep 3, 2018

Editing Vshops's entity type and then reloading the config resets the villager and makes the shop go away

image

@sfxworks
Copy link
Author

sfxworks commented Sep 3, 2018

I can also no longer delete this shop or identify this shop in game.

@sfxworks
Copy link
Author

sfxworks commented Sep 4, 2018

image
When deleting the shop, reloading sponge plugins & the world the shop was in still keep the entity.

The only way to kill it is to take a sword and kill it.

@Valandur Valandur self-assigned this Sep 4, 2018
@Valandur Valandur added the bug Things that don't work the way they should label Sep 4, 2018
@DosMike
Copy link
Contributor

DosMike commented Mar 5, 2019

@sfxworks Was the chunk unloaded while you tried to delete it?

@sfxworks
Copy link
Author

sfxworks commented Mar 6, 2019

It is our spawn, so unlikely but possible.

@DosMike
Copy link
Contributor

DosMike commented Mar 6, 2019

I'm asking since shops turning into mobs is usually a sign of the shop being deleted without the mob being removed, and that'd make it a problem in my API.
I can change a few bits around for my next release but I'm currently working on a new menu implementation.

@sfxworks
Copy link
Author

sfxworks commented Mar 6, 2019

I've resigned from the network responsible for this, so I let them know about your response and am passing the issue onto them.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Things that don't work the way they should
Projects
None yet
Development

No branches or pull requests

3 participants