Respond to PR Feedback #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made an example project if you'd like to test this: https://github.com/doug-wade/jest-fail-on-console-client |
|
Thanks for this fix. I actually just merged a PR that added the missing methods to the documentation so could you please rebase your PR and adjust accordingly ? 🙂 |
doug-wade
force-pushed
the
document-fail-on-assertion-failure
branch
from
a3a50af to
d9d38c8
Compare
This was referenced Apr 12, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FloEdelmann left some great feedback on #15 (review) after the PR was merged. This addresses that feedback.