Skip to content

[Rust API] Better return values for errors #3245

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
ElykDeer opened this issue Jul 6, 2022 · 1 comment
Open

[Rust API] Better return values for errors #3245

ElykDeer opened this issue Jul 6, 2022 · 1 comment
Assignees
@emesare
Labels
Component: API Issue needs changes to the API Component: Rust API Issue needs changes to the Rust API Effort: Medium Issue should take < 1 month Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality

Comments

@ElykDeer
Copy link
Member

ElykDeer commented Jul 6, 2022

As it stands we just return Err(()) in a lot of places. We should replace all those with more informative errors.

See discussion in #2976, there's also a lot of related discussion lost to public slack history.
@ElykDeer ElykDeer added Type: Enhancement Issue is a small enhancement to existing functionality Component: API Issue needs changes to the API needs refactor Impact: Low Issue is a papercut or has a good, supported workaround Effort: Medium Issue should take < 1 month Component: Rust API Issue needs changes to the Rust API labels Jul 6, 2022
@ElykDeer ElykDeer mentioned this issue Jul 6, 2022
Closed
@emesare emesare self-assigned this Jul 26, 2024
@emesare
Copy link
Member

emesare commented Aug 5, 2024

Another one is returning empty vecs instead of errors or optional values

binaryninja-api/rust/src/interaction.rs

Line 531 in ce5995c

vec![]

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@emesare emesare

Labels
Component: API Issue needs changes to the API Component: Rust API Issue needs changes to the Rust API Effort: Medium Issue should take < 1 month Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fuzyll @ElykDeer @emesare