-
Notifications
You must be signed in to change notification settings - Fork 155
fix: dart_frog build in a pub workspace (dart ^3.5) #1518
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Hi @Leptopoda 👋 Thanks for opening this issue! In talking with the team we do believe that this is a valid bug as we have not added in support for Workspaces at this time to any of our packages. The main reason for this is that overall the Workspaces feature is still experimental from the Dart team. This was pointed out by the team in the post announcing the 3.5 release
Given this, I'm going to leave the issue open as it is valid but we won't plan on re-evaluating it until the Workspace feature is complete and fully launched by the Dart team. |
It might be time to re evaluate as workspaces hit GA a few days ago with dart 3.6 |
Notes from Grooming Session with team
|
Not having workspace support has now become a major roadblock for us. We've been using dart_frog for a long time now in our MMORPG, and we've converted all of our packages that are shared between different projects to use workspace resolution. dart_frog not supporting this now means we need to have separate branches where that is disabled for our packages, which is a major hassle to deal with and creates a lot of unnecessary overhead. And not having the better dependency management, easier local development, unified tooling and improved analyzer performance are making us doubt if we should keep using dart_frog as our server infrastructure unless this is enabled. At least clear communication when workspace support will be released for dart_frog would be something that would make us feel better to keep using dart_frog. |
I'm currently working on a PR to support workspaces on my dart_frog fork. I have progress on it regarding getting dependencies from This is my working PR. |
Description
dart_frog build
fails when run in a pub workspace package.The issue seems to be that a pub workspace will only generate one global
pbspec.lock
file for the entire repository. Therefore, the post gen hook of thedart_frog_prod_server
mason module fails.Steps To Reproduce
cd packages/api
(the package our server code is living in)dart_frog build
⚡Expected Behavior
dart_frog manages to build the server code.
Additional Context
For reference, pub workspaces are the new dart native mono repo management, which is currently in preview since dart 3.5.
More info at: https://flutter.dev/go/pub-workspace
The text was updated successfully, but these errors were encountered: