Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Popup anchor issue since OL 4.5.0 #65

Closed
pjmeier opened this issue Dec 22, 2017 · 5 comments
Closed

Popup anchor issue since OL 4.5.0 #65

pjmeier opened this issue Dec 22, 2017 · 5 comments
Labels

Comments

@pjmeier
Copy link

pjmeier commented Dec 22, 2017

The anchor for the popup overlay is not positioned correctly when used with OL 4.5.0 or greater.
You can see the issue in the demo as it's using the latest OL : http://viglino.github.io/ol3-ext/examples/map.popup.html

@Viglino
Copy link
Owner

Viglino commented Dec 23, 2017

Yes there is an issue on the anchor position. I think it's just a CSS issue...

@pjmeier
Copy link
Author

pjmeier commented Dec 24, 2017

That's what I thought. The ol.css hasn't changed since the issue though. I did have a look hoping it would be an easy fix but ran out of time. I've rollback to using a previous version of OL in the meantime and may look at it again after the festive season.

@Viglino
Copy link
Owner

Viglino commented Dec 24, 2017

OK, it's not just a CSS issue.
The last commit solves the issue.

@Viglino Viglino added the bug label Dec 24, 2017
@pjmeier
Copy link
Author

pjmeier commented Dec 27, 2017

Fantastic work.
I noticed that stop event is set to false on line 28 of the popupoverlay.js whereas previously it was true. Having it false causes some issues on my popup that has buttons and tooltips. Should it be true or is there a reason it's set to false?

Viglino added a commit that referenced this issue Dec 30, 2017
@Viglino
Copy link
Owner

Viglino commented Dec 30, 2017

I put the option back to true (I think it was just a test).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants