Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Comma (",") Not Supported in Link or Linkify Rules #37

Open
madebycaliper opened this issue Oct 7, 2020 · 0 comments
Open

Comma (",") Not Supported in Link or Linkify Rules #37

madebycaliper opened this issue Oct 7, 2020 · 0 comments

Comments

@madebycaliper
Copy link

I've been struggling to figure this out for hours thinking that it was the pre and post-render functions I created, but after seeing the commit messages and Issue #8 (Links can't contain "?" character") I believe it's due to the lack of support of commas in the urlPath. I tried to build and test locally but ran into terminal errors and didn't have the time to dig any further into it. I think it would only require an extra , char where the ? was inserted in link.js and linkify.js. I'll try creating a PR on Github so you don't have to the work yourself.

Is there any reason you wouldn't want to allow commas? The link I've been using as an example is a Google Maps link:

https://www.google.com/maps/place/Echo+Park,+Los+Angeles,+CA/data=!4m2!3m1!1s0x80c2c6e72cab485b:0x5d1e51181d0cec80?sa=X&ved=2ahUKEwi87frD26HsAhVKXK0KHWEvAWMQ8gEwH3oECCUQBA

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant