Update alert.js #66
Merged
Update alert.js #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the modal from closing onConfirm and onCancel
|
This needs to be behind an option. In 99% of cases the alert will need to close when the button is pressed, so the default would need to do this. Adding new options |
|
Alright, I can work on this tonight. Thanks for the feedback. |
|
OK, I updated the plugin by adding two new options:
Still think it's a little overkill since 2 to 4 parameters need initializing just to prevent an alert from closing. |
VizuaaLOG
pushed a commit
that referenced
this pull request
Jun 23, 2019
* Update alert.js Prevent the modal from closing onConfirm and onCancel * Add options to prevent an alert from closing
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #64.
Prevent the modal from closing on onCancel() and onConfirm().