Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug: train_asr_eval=false causes run.sh to crash #30

Open
egaznep opened this issue Oct 14, 2022 · 0 comments
Open

Bug: train_asr_eval=false causes run.sh to crash #30

egaznep opened this issue Oct 14, 2022 · 0 comments

Comments

@egaznep
Copy link

egaznep commented Oct 14, 2022

I have found a bug within the challenge evaluation framework, which causes the software to fail when train_asr_eval or train_asv_eval is set to false instead of the default value true.

The problem is caused by line 19 in main_eval_asr.sh and line 80 in main_eval_asv.sh which are almost the same except 'asv' instead of 'asr'.

if [ $train_asr_eval ]; then

This test expression always evaluates to true, even when the corresponding config entry is set to false or 0.

It could be fixed by changing the braces with parentheses. I can open up a pull request if desired.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant