Skip to content

refactor(UserAPIController): Extract RunInfoController #292

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
hirokiterashima opened this issue Mar 18, 2025 · 0 comments · May be fixed by #296
Open

refactor(UserAPIController): Extract RunInfoController #292

hirokiterashima opened this issue Mar 18, 2025 · 0 comments · May be fixed by #296
Assignees
Labels
Code Quality Improves code quality

Comments

@hirokiterashima
Copy link
Member

In UserAPIController, we have

  @GetMapping("/run/info-by-id")
  HashMap<String, Object> getRunInfoById(Authentication auth, @RequestParam("runId") Long runId) {

In StudentAPIController, we have

  @GetMapping("/run/info")
  HashMap<String, Object> getRunInfoByRunCode(@RequestParam("runCode") String runCode) {

These endpoints don't have much to do with a User. It has more to do with RunInfo.

Tasks:

  • Move the function endpoints to a new class, RunInfoController
  • Also move the corresponding tests to RunInfoControllerTest.java
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code Quality Improves code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants