Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(Branch Authoring): UX improvements #1967

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

breity
Copy link
Member

@breity breity commented Oct 28, 2024

Changes

  • Add dialog to explain branch criteria options in create and edit branch structure pages
  • Add hint text to merge step select in create branch page
  • Add descriptive icons to Add Step button menu in Unit Home

Test

  • Make sure create branching structure works as before.
  • Make sure edit branching structure works as before.
  • Make sure "Add step before", "Add step after", And "Branch off this step" options in the Add Step dropdown menu work as before.

@breity breity added the enhancement New feature of any size or improvement (UI, performance, security) label Oct 28, 2024
@breity breity self-assigned this Oct 28, 2024
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


constructor(protected dialog: MatDialog) {}

showCriteriaHelp(): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protected?

@breity breity merged commit dfd8e2c into develop Oct 29, 2024
5 checks passed
@breity breity deleted the branch-authoring-ux-improvements branch October 29, 2024 18:06
@hirokiterashima
Copy link
Member

🎉 This issue has been resolved in version 5.161.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature of any size or improvement (UI, performance, security) released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants