Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Docs are still for OAuth1 #56

Open
kosso opened this issue Feb 25, 2019 · 3 comments
Open

Docs are still for OAuth1 #56

kosso opened this issue Feb 25, 2019 · 3 comments

Comments

@kosso
Copy link
Contributor

kosso commented Feb 25, 2019

The documentation needs updating for OAuth2

https://github.com/WP-API/OAuth2/blob/master/docs/basics/Signing.md
@kosso
Copy link
Contributor Author

kosso commented Feb 25, 2019

Never mind. I found these : https://developer.wordpress.com/docs/oauth2/

@kosso kosso closed this as completed Feb 25, 2019
@kosso
Copy link
Contributor Author

kosso commented May 30, 2019

Reopening this, since the documentation linked above is only for wordpress.com

@kosso kosso reopened this May 30, 2019
@runofthemill
Copy link

Updated docs would be great!

Outside of the existing docs, it would be good to have info on the use of wp_safe_redirect() and how to filter the list of external hosts; the change from wp_redirect() to wp_safe_redirect() in 02d47e5#diff-e60a82a0cee7b25ba6509ae636d516db broke functionality, and it took quite a bit of work to figure out I needed to hook into allowed_redirect_hosts to fix things. If you'd like, I can submit a PR to add info about this, but I'm not sure where it should live.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kosso @runofthemill