Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WEB_PROCESS_CMD_PREFIX can not be used #16

Closed
elecro opened this issue Jun 27, 2013 · 6 comments
Closed

WEB_PROCESS_CMD_PREFIX can not be used #16

elecro opened this issue Jun 27, 2013 · 6 comments

Comments

@elecro
Copy link

elecro commented Jun 27, 2013

Nowadays the Nix port uses the LauncherGtk to start the webprocess and due to this the section "Debugging" in the Readme.nix can not be applied. The WEB_PROCESS_CMD_PREFIX is not used by the WebKit2 at all.

This was really a neat way of debugging the WebProcess. How should we restore this functionality? Should be implement it in the LauncherGtk or we'll create our own LauncherNix?

@qrwteyrutiyoup
Copy link
Member

I took a quick look at implementing it in Gtk Launcher a few days ago, but at first glance it wasn't going to be that easy, since Gtk launches a libtool script (bash) which then launches the actual WebProcess binary. So, prefixing this libtool script with gdb, for instance, wasn't going to work (easily).

To just restore this functionality for now - which I agree is neat - I think we could just clone the Gtk launcher and create our own Nix launcher.

@elecro
Copy link
Author

elecro commented Jun 27, 2013

Or can't we just go back to the Efl launcher?

@qrwteyrutiyoup
Copy link
Member

Yeah, that's also an option, and we seem to keep switching between them. I am not sure why we changed back to Gtk launcher again, but it may have to do with the fact Efl workqueue is currently buggier: https://bugs.webkit.org/show_bug.cgi?id=114432 / https://bugs.webkit.org/show_bug.cgi?id=115332.

@elecro
Copy link
Author

elecro commented Jun 27, 2013

How about a solution like this elecro/webkitnix@888c54b ?

@elecro
Copy link
Author

elecro commented Jun 27, 2013

Ahh... yeah a forgot to do a git add :) sorry. This is the patch's patch elecro/webkitnix@9ad14e1.

And a compare view: https://github.com/elecro/webkitnix/compare/webprocess_debug

@qrwteyrutiyoup
Copy link
Member

Closing the issue, as commit e25ceb7 has landed. Thanks @elecro.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants