Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PHP Notice on login when Login Welcome Page is not set #75

Closed
raamdev opened this issue Mar 27, 2014 · 1 comment
Closed

PHP Notice on login when Login Welcome Page is not set #75

raamdev opened this issue Mar 27, 2014 · 1 comment
Labels
bug

Comments

@raamdev
Copy link
Contributor

raamdev commented Mar 27, 2014

When a Login Welcome Page hasn't been set (as might be the case after installing s2Member but not completing its configuration), a PHP notice is thrown upon logging in as an s2Member user because s2Member assumes a Login Welcome Page is always set:

Notice: Trying to get property of non-object

I'm submitting a Pull Request with a fix that checks $GLOBALS["WS_PLUGIN__"]["s2member"]["o"]["login_welcome_page"] before passing it to get_page_link() in s2member/includes/classes/#-redirects.inc.php (which is throwing this notice).
@raamdev raamdev added the bug label Mar 27, 2014
raamdev added a commit to raamdev/s2Member that referenced this issue Mar 27, 2014
@raamdev
Check if Login Welcome Page is set before redirecting to it. See wpsh…
73d2e93 
…arks#75
@raamdev raamdev mentioned this issue Mar 27, 2014
Merged
@jaswrks
Copy link
Contributor

jaswrks commented Mar 28, 2014

Merged. Thank you!

@jaswrks jaswrks closed this as completed Mar 28, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raamdev @jaswrks