New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use ISO standard for day numbering #84

Open

WickyNilliams opened this issue Feb 8, 2025 · 0 comments

Labels

breaking change

Owner

WickyNilliams commented Feb 8, 2025 •

edited

Loading

Right now I use the JS 0-indexed approach for day numbering throughout the codebase e.g.

Sunday 0
Monday 1
etc

This is used consistently throughout cally:

firstDayOfWeek defaults to 1 but is 0-indexed
CSS parts for day numbers e.g. day-0

But since the goal is to move entirely to Temporal API when it's available, we should switch to the ISO standard of 1-indexed day numbering.

Unfortunately this is a breaking change, so I will likely save for v1

The text was updated successfully, but these errors were encountered:

WickyNilliams added the breaking change label

WickyNilliams mentioned this issue

Open

# for free to join this conversation on GitHub. Already have an account? # to comment