Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Documentation with broken JS #5

Closed
michaelwitk opened this issue Oct 28, 2017 · 3 comments
Closed

Documentation with broken JS #5

michaelwitk opened this issue Oct 28, 2017 · 3 comments

Comments

@michaelwitk
Copy link
Contributor

michaelwitk commented Oct 28, 2017 •
edited by Wikiki
Loading

https://wikiki.github.io/bulma-extensions/slider#sliderJsExample

See PR #4
@Wikiki
Copy link
Owner

Wikiki commented Oct 28, 2017

Sorry, I revert your PR because the initial code was good. It's slider input which have has-output class. So the test is on the right variable (slider and not output)

Regards

@Wikiki Wikiki closed this as completed Oct 28, 2017
@michaelwitk
Copy link
Contributor Author

It is indeed good, I did also only spot it after you accepted my PR.
But the docs do not provide working JS code.

ewl6nwi

@Wikiki
Copy link
Owner

Wikiki commented Oct 30, 2017

You're right, thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelwitk @Wikiki