Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

What remove for similar features #33

Open
Sandy4321 opened this issue Dec 6, 2019 · 2 comments
Open

What remove for similar features #33

Sandy4321 opened this issue Dec 6, 2019 · 2 comments

Comments

@Sandy4321
Copy link

May you clarify what are you doing with colinear features
What you remove from let's say 3 similar features
Which one?

@hppy139
Copy link

hppy139 commented Oct 29, 2020

Facing the same question. @Sandy4321
Unfortunately, in your example, the code to_drop = [column for column in upper.columns if any(upper[column].abs() > correlation_threshold)](in line 201 of feature_selector.py) will remove 2 features, remaining the 1st feature in the upper triangular correlation matrix.
Does it?

@Sandy4321
Copy link
Author

any answer pls

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants