Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Compilation error under node 17 #711

Closed
zdm opened this issue Oct 19, 2021 · 2 comments
Closed

Compilation error under node 17 #711

zdm opened this issue Oct 19, 2021 · 2 comments

Comments

@zdm
Copy link

zdm commented Oct 19, 2021

Some APIs were changed or removed in node v17, better-sqlite3 requires uodate.

Temp\prebuild\node\17.0.0\include\node\v8-persistent-handle.h(10,10): fatal error C1083: Cannot open include file: 'v
8-weak-callback-info.h': No such file or directory (compiling source file ..\src\better_sqlite3.cpp) [d:\downloads\package\build\better_sqlite3.vcxproj]
@Prinzhorn
Copy link
Contributor

This appears to be a bug in Node.js, not better-sqlite3

nodejs/node#40526

@zdm
Copy link
Author

zdm commented Oct 21, 2021

Yes, fixed in node v17.0.1.

@zdm zdm closed this as completed Oct 21, 2021
@Prinzhorn Prinzhorn mentioned this issue Nov 3, 2021
Closed
@amchiclet amchiclet mentioned this issue Apr 29, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Prinzhorn @zdm