Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SoapClient should not be static #117

Closed
cheindl opened this issue Oct 13, 2017 · 2 comments
Closed

SoapClient should not be static #117

cheindl opened this issue Oct 13, 2017 · 2 comments
Assignees

Comments

@cheindl
Copy link

cheindl commented Oct 13, 2017

I have a project with several, different Webservices (different WSDLs) where i generated client classes with the generator.

When i try to use multiple services within one php runtime, i get problems as each client shares the same instance of AbstractSoapClientBase::soapClient.

IMHO there are two solutions:

  • AbstractSoapClientBase::soapClient will be made an instance variable
  • AbstractSoapClientBase::soapClient should be defined some where further down in the hierarchy (per WSDL client)
@mikaelcom
Copy link
Member

I understand your issue. First thing first, could you create this issue at the PackageBase project as it does concern the PackageGenerator project actually.

@mikaelcom mikaelcom self-assigned this Oct 13, 2017
@cheindl
Copy link
Author

cheindl commented Oct 14, 2017

In a way it also affects the PackageGenerator project, as client generation must be changed, if changes are made in AbstractSoapClientBase. I created now PackageBase#15 to address the issue in PackageBase project.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants