Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[request] Change the way Modulus deploys a Meteor App #235

Open
mycyberacademy opened this issue Sep 28, 2016 · 1 comment
Open

[request] Change the way Modulus deploys a Meteor App #235

mycyberacademy opened this issue Sep 28, 2016 · 1 comment

Comments

@mycyberacademy
Copy link

mycyberacademy commented Sep 28, 2016

Currently, if I upload a meteor source code to modulus, it does these tasks:

  • Install npm packages present in package.json file.
  • Demeteorize the app using specified meteor version in .meteor/release

The 2nd step includes installing meteor specific packages, the ones the project uses. If one of those packages makes changes to package.json file, meteor throws a message saying that changes to package.json was made, and meteor npm install needs to be done again.

As a result modulus script halts without success:

Your package.json has been updated. Please, run npm install in your project directory.
Conversion failed.

The meteor package who make those changes is called webpack:weback. Please change modulus script so it could notice it has to run npm install again and doesn't halt.

I tested this out with meteor 1.4.1.
This will fix #224 too.

@jackboberg
Copy link
Contributor

This is great feedback/research. Some of the changed you are suggesting actually make more sense currently in the build-meteor image issues instead of here. That said, I will spend some time thinking about how the next release of demeteorizer might resolve this (and related) issues instead of just solving it for the Modulus platform.

Thanks @mycyberacademy

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants