check if npm needs update

[jackboberg]

After sourcing versions from root package.json (via demeteorizer), we need to check if a new version of npm was requested. Using these properties:

  "engines": {
  	"node": "4.5.0",
  	"npm": "latest"
  }

I get this:

Demeteorization complete.
Now using node v4.5.0 (npm v2.15.9)
deploy -> v4.5.0 *

It looks like we are updating the version, just not printing the right information.

[jackboberg]

The output is from nvm here

[jackboberg]

we could remove the > /dev/null 2>&1, but it would make the build output ugly. Maybe we just hide nvm install and instead write a user friendly line that states which version were installed after complete?

[theworkflow]

What exactly is the point of updating npm if the user sets it in the package.json? I do understand your case here though. But also, since node@v4.5.0 ships with npm@2.15.9 wouldn't there be a problem updating from that version to latest (which is currently v4.0.5)?

[jackboberg]

npm rebuild probably needs to happen after npm install npm@$NPM_VERSION

[theworkflow]

What about NPM_VERSION = NPM_VERSION || 'latest'?

[vladejs]

@jackboberg
Since meteor > 1.4 bcrypt package needs to be compiled when deploying an app, so yes, npm rebuild in meteor 1.4 apps needs to be done afrer npm install.

Please let me know when this is fixed. I still can't setup CI on modulus with CodeShip.

[jackboberg]

@vladejs Just to be clear, we are rebuilding after npm install (which happens in demeteorizer step). Certainly issues with bcrypt and compiled modules after changing node version, but we are rebuilding after that as well..

I plan on fixing our order, but are we sure this issue is due to npm version?

[vladejs]

I think it's solved:

Now using node v4.5.0 (npm v4.0.5)
Found package.json: ./bundle/programs/server/package.json
Running command: npm start