Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add post-rotate test #12

Open
abrunnin-xilinx opened this issue Apr 29, 2024 · 0 comments
Open

Add post-rotate test #12

abrunnin-xilinx opened this issue Apr 29, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@abrunnin-xilinx
Copy link
Contributor

We should self-test the post-rotate command actually executes. (Both on time and on byte count.)

Note that it is known that when you cause solarcapture to quit (via ^C) this kills it before it spawns a final rotate command. Which is sort of legitimate (we didn't rotate, after all) but is actually kind of annoying. So the test would need to note that as a known exception.

Sadly, just adding a new call to the postrotate on exit isn't quite enough - if it's done in the wrapper script, then it fires before the last packets are flushed to the pcap, and if it is done in the C code then the python wrapper is already dead and so isn't around to respond to the request to run an additional rotation. Needs some though t on how to implement properly.

@abrunnin-xilinx abrunnin-xilinx added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant