Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix QCDQDecoupledWeightQuantProxyHandlerMixin return args #747

Closed
Giuseppe5 opened this issue Nov 1, 2023 · 2 comments
Closed

Fix QCDQDecoupledWeightQuantProxyHandlerMixin return args #747

Giuseppe5 opened this issue Nov 1, 2023 · 2 comments
Assignees
@costigt-dev
Labels
good first issue Good for newcomers

Comments

@Giuseppe5
Copy link
Collaborator

brevitas/src/brevitas/export/common/handler/qcdq.py

Line 171 in 513ab4d

return out, scale, zero_point, scale, zero_point, bit_width

Bitwidth is in the wrong place
@OscarSavolainen
Copy link
Contributor

Is this issue still open? QCDQDecoupledWeightQuantProxyHandlerMixin seems to have been entirely removed from the coeebase.

@Giuseppe5
Copy link
Collaborator Author

We just made its name longer :)

@Giuseppe5 Giuseppe5 added the good first issue Good for newcomers label Feb 19, 2024
@costigt-dev costigt-dev self-assigned this Feb 21, 2024
@costigt-dev costigt-dev mentioned this issue Feb 21, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@costigt-dev costigt-dev

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Giuseppe5 @OscarSavolainen @costigt-dev