Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QuantTensor's __truediv__ always results in a NaN zero-point when both inputs have a 0 zero point #767

Closed
nickfraser opened this issue Nov 23, 2023 · 1 comment

Comments

@nickfraser
Copy link
Collaborator

Spotted while working on #740. The following branch:

            if self.is_zero_zero_point(self) and self.is_zero_zero_point(other):
                output_zero_point = self.zero_point / other.zero_point

Ensures that the output always has a NaN zero point (i.e., 0 / 0 = NaN). I assume we would like the output zero point to also be zero.

@nickfraser
Copy link
Collaborator Author

Closed by #768.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant