Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PC-000] 약관 상세 화면 웹뷰가 렌더링 되기 이전 TopBar가 가려지던 것 해결 #28

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Jan 9, 2025

1. ⭐️ 변경된 내용

  • 약관 상세 화면 웹뷰가 렌더링 되기 이전 TopBar가 가려지던 것 해결

2. 🖼️ 스크린샷(선택)

2025-01-09.10.41.33.mov

@tgyuuAn tgyuuAn added 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 잡다한 🗂️ 허드렛일...! ㅌㄱ태규 ☀️ 훗날 크게될 ENFP 남성, tgyuuAn labels Jan 9, 2025
@tgyuuAn tgyuuAn self-assigned this Jan 9, 2025
Comment on lines -24 to -25
packaging { resources { excludes += "/META-INF/*" } }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 녀석 때문에 LayoutInspector가 동작안하고 있었습니다..

제거하니까 동작하더군요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

허허 저 코드가 항상 뭐하는 코드인지 잘 몰랐는데 한번 찾아봐야겠군요...!!

@@ -37,7 +38,8 @@ internal fun RegistrationDetailScreen(
url = term.content,
modifier = Modifier
.fillMaxWidth()
.weight(1f),
.weight(1f)
.clipToBounds(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LayoutInspector 상으로는 레이아웃이 적절하게 배치되어있는데,

아무래도 WebView가 주어진 영역을 침범하는 것 같더라고요.

clipToBounds() 를 적용시키니 바로 해결되었습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

느낌 상으로는 weight(1f)로도 될 거 같은데... 웹뷰만의 특징인건가...?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

느낌 상으로는 weight(1f)로도 될 거 같은데... 웹뷰만의 특징인건가...?!

그런가봐요.... 잘 모르겠네요 ㅠㅠㅠㅠㅠㅠ

@sksowk156 sksowk156 added 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟 and removed 리뷰 원해요🔥 피어의 리뷰를 기다리는 ing.. 🔥 labels Jan 9, 2025
@tgyuuAn tgyuuAn merged commit 8a396f4 into develop Jan 9, 2025
1 check passed
@tgyuuAn tgyuuAn deleted the chore/tgyuu/PC-000 branch January 9, 2025 13:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ㅌㄱ태규 ☀️ 훗날 크게될 ENFP 남성, tgyuuAn 머지 해도될듯염🌟 현재 코드를 기존 코드에 합쳐도 될 것 같다라고 판단..! 🌟 잡다한 🗂️ 허드렛일...!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants