-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[PC-386] 세팅 ui 구현 #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와우 진혁님 코드가 많군요 하하
고생많으셨습니다~ 저희 화면이 거의 MVP 목표치에 도달하고 있꾼요 하하
UI가 이쁘게 나와서 제가 다 기분이 좋네요 ㅎㅎㅎㅎ
코멘트 사소한 것 달아보았구 추가적으로,
탈퇴 사유 작성 칸에서 "기타"를 눌렀을 경우 사유가 없으면 버튼이 비활성화되는 규칙을 넣어주시면 좋을 것 같습니다!

그리고 영상의 22초 ~ 24초 Keyboard 올라왔을 때 다음 화면으로 넘어가면서 키보드가 갑자기 뚝 떨어지는게 부자연스러워 보이는 것 같아요.
이 부분 키보드를 내리고 전환시킨다거나 더 자연스럽게 만들어주시면 좋을 것 같습니다!
디자이너님께 여쭤봐도 되고 진혁님이 일시적으로 이뻐보이는 것으로 만들어주셔도 좋습니다!
이것 외에는 Raw Text들 String으로 분리해주시면 머지 될 것 같습니다!!
feature/setting/src/main/java/com/puzzle/setting/graph/main/SettingViewModel.kt
Outdated
Show resolved
Hide resolved
feature/setting/src/main/java/com/puzzle/setting/graph/main/SettingViewModel.kt
Outdated
Show resolved
Hide resolved
feature/setting/src/main/java/com/puzzle/setting/graph/withdraw/WithdrawViewModel.kt
Outdated
Show resolved
Hide resolved
feature/setting/src/main/java/com/puzzle/setting/graph/withdraw/WithdrawViewModel.kt
Outdated
Show resolved
Hide resolved
feature/setting/src/main/java/com/puzzle/setting/graph/withdraw/WithdrawScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구우우우우우우웃~~~
야뮝~~~ 고생하셨어요 ㅎㅎㅎㅎㅎㅎㅎ
1. ⭐️ 변경된 내용
2. 🖼️ 스크린샷(선택)
KakaoTalk_20250122_023045068.mp4
3. 💡 알게된 부분
' android:windowSoftInputMode="adjustResize"'를 선언해줘야 하더라구요.
4. 📌 이 부분은 꼭 봐주세요!