From c47204200620f48a98197a3318b47aa0bbac36b3 Mon Sep 17 00:00:00 2001
From: Avi Schwab <froboy@gmail.com>
Date: Fri, 13 Dec 2024 15:02:54 -0600
Subject: [PATCH] Handle nolink menu items properly.

---
 templates/menu--main.html.twig | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/templates/menu--main.html.twig b/templates/menu--main.html.twig
index 3cab6be..01ab323 100644
--- a/templates/menu--main.html.twig
+++ b/templates/menu--main.html.twig
@@ -50,9 +50,14 @@
               {% elseif item.url.options.attributes.class %}
                 {% set nav_link_classes = nav_link_classes|merge([item.url.options.attributes.class]) %}
               {% endif %}
+              {% if item.url.isRouted and item.url.routeName is not same as '<nolink>' %}
+                {% set menu_item_href = "href=#{item.url|render}" %}
+              {% else %}
+                {% set menu_item_href = '' %}
+              {% endif %}
               {% if item.below %}
                 <li class="dropdown nav-level-2 children">
-                  <a href="{{ item.url }}" class="menu-link--level-1" aria-expanded="false" data-toggle="dropdown">
+                  <a {{ menu_item_href }} class="menu-link--level-1" aria-expanded="false" data-toggle="dropdown">
                     {{ item.title }}&nbsp;
                     {{ chevron }}
                   </a>
@@ -60,7 +65,7 @@
                 </li>
               {% else %}
                 <li class="dropdown nav-level-2">
-                  <a href="{{ item.url }}" target="_self" class="menu-link--level-1">
+                  <a {{ menu_item_href }} target="_self" class="menu-link--level-1">
                     {{ item.title }}&nbsp;
                   </a>
                 </li>
@@ -85,7 +90,12 @@
                 <a href="#" class="back">{{ navigationLinkLabel }}</a>
               </div>
               <div class="navigation-bottom">
-                <a href="{{ parent.url }}" class="main-menu-link--level-1">
+                {% if parent.url.isRouted and parent.url.routeName is not same as '<nolink>' %}
+                  {% set menu_parent_href = "href=#{parent.url|render}" %}
+                {% else %}
+                  {% set menu_parent_href = '' %}
+                {% endif %}
+                <a {{ menu_parent_href }} class="main-menu-link--level-1">
                   {{ parent.title }}
                 </a>
               </div>