New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Code clarity over Cleverness or Brevity #25

Open

actual-saurabh opened this issue Oct 19, 2016 · 5 comments

Labels

enhancement Hacktoberfest

Member

actual-saurabh commented Oct 19, 2016

https://github.com/yapapaya/live-comment-preview/blob/master/classes/class-live-comment-preview.php#L202-L213 is clever and short, but not clear, especially to a newbie.

This method needs to be rewritten so that the method calls are coded explicitly.

actual-saurabh added enhancement Hacktoberfest labels

adiman9 commented Oct 20, 2016

On it :)

adiman9 commented Oct 20, 2016

#28 fixes this

mariadanieldeepak commented Nov 9, 2016

Since #28 is merged, kindly mark this issue as closed.

Member Author

actual-saurabh commented Nov 9, 2016

Would like to review this issue post #23 and then close it.

mariadanieldeepak commented Nov 10, 2016

Cool, thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment