Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support merging existing resources #20

Open
ZacSweers opened this issue Jun 26, 2021 · 1 comment
Open

Support merging existing resources #20

ZacSweers opened this issue Jun 26, 2021 · 1 comment

Comments

@ZacSweers
Copy link
Owner

Requires google/ksp#431

@bubenheimer
Copy link

I think the auto-service-ksp processor code currently does not even merge its own resources, i.e. multiple rounds would overwrite each other or it would throw. It looks like there is an intention to gather everything for a later write, like SymbolProcessor.finish(), but then, actually, writes are not being deferred. Or does CodeGenerator.createNewFile() actually append? Maybe I missed something or it's left incomplete because of this issue. Just thought I'd share my findings from studying the code.

https://github.com/ZacSweers/auto-service-ksp/blob/main/processor/src/main/kotlin/dev/zacsweers/autoservice/ksp/AutoServiceSymbolProcessor.kt

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants