Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

change(CI): Refactor creating GCP disks #8330

Merged
merged 1 commit into from
Feb 29, 2024
Merged

change(CI): Refactor creating GCP disks #8330

merged 1 commit into from
Feb 29, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 27, 2024 •
edited
Loading

Motivation

PR #8305 provided a fast solution to #8302. This PR refactors the fix for better maintenance.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Testing & Review

We should check that creating the disks works when the get-disk-name job both does and doesn't run.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles C-tech-debt Category: Code maintainability issues P-Low ❄️ labels Feb 27, 2024
@upbqdn upbqdn requested a review from a team as a code owner February 27, 2024 13:40
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 27, 2024
@upbqdn upbqdn force-pushed the refactor-gcp-disks branch from b40f9ff to 36fe0ff Compare February 27, 2024 15:45
@mpguerra mpguerra linked an issue Feb 28, 2024 that may be closed by this pull request
ci: Creating GCP instances without cached disks fails #8302
Closed
gustavovalverde
gustavovalverde approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit 6a6f286 into main Feb 29, 2024
128 checks passed
@mergify mergify bot deleted the refactor-gcp-disks branch February 29, 2024 14:46
@arya2 arya2 mentioned this pull request Apr 15, 2024
Merged
43 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees
No one assigned
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-tech-debt Category: Code maintainability issues C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: Creating GCP instances without cached disks fails
2 participants
@upbqdn @gustavovalverde