Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Transparency & Consistency of nuget builds #309

Closed
kitsumed opened this issue Feb 3, 2025 · 1 comment · Fixed by #312
Closed

Transparency & Consistency of nuget builds #309

kitsumed opened this issue Feb 3, 2025 · 1 comment · Fixed by #312
Assignees

Comments

@kitsumed
Copy link
Contributor

kitsumed commented Feb 3, 2025

Hi, Ive been using your library for a while now and it is working well, however I do have some disappointment about the way nuget builds are made and published.

Currently, the build process is not public, and does not include :

  • Symbols
  • Deterministic build
  • Compiler Flags
    You can see them here under Health for version 6.15.0.

This could make debugging more challenging (due to missing symbols) and add concerns about ensuring that the NuGet package matches the source code from the github repo. Until now, I used a decompiler and some tools to compare code difference, but this isn't efficient.

As I recently had to look into making a github workflow to publish to nuget, I was wondering if you would be interessed If I made a pull request to create a release workflow for your project too.

@Zeugma440 Zeugma440 self-assigned this Feb 3, 2025
@Zeugma440
Copy link
Owner

Hi there and thanks for your feedback.

The publishing process has been the same for years :

  1. Once a version is stabilized, I synch my local repo with the central repo
  2. I generate the NuGet package on my local device, calling Microsoft tools from a .bat script file
  3. I upload the generated package to NuGet manually
  4. I increment the library's version number right after that

I didn't even realize what you describe could be an actual issue.

As I recently had to look into making a github workflow to publish to nuget, I was wondering if you would be interessed If I made a pull request to create a release workflow for your project too.

Yes, definitely! Thanks in advance~

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants