Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Request: Thumbfast support #22

Open
Cananbolt opened this issue Oct 8, 2022 · 2 comments · May be fixed by #24
Open

Request: Thumbfast support #22

Cananbolt opened this issue Oct 8, 2022 · 2 comments · May be fixed by #24

Comments

@Cananbolt
Copy link

Cananbolt commented Oct 8, 2022

When using the new thumbnail script, thumbfast.lua it didn't generate any thumbnails, I figured it may be because this script uses mpv_thumbnail_script. I was wondering if it would be possible to either replace mpv_thumbnail_script or add support to thumbfast.lua.

@Zren
Copy link
Owner

Zren commented Oct 8, 2022

Hmm, so it spawns a mpv background process with an open pipe. When you need the thumbnail, it will send a seek command to the pipe which draws the thumbnail to file. Neat.

   if os_name == "Windows" then
        seek_command = {"cmd", "/c", "echo "..command.." > \\\\.\\pipe\\" .. options.socket}
    elseif os_name == "Mac" then
        -- this doesn't work, on my system. not sure why.
        seek_command = {"/usr/bin/env", "sh", "-c", "echo '"..command.."' | nc -w0 -U " .. options.socket}
    else
        seek_command = {"/usr/bin/env", "sh", "-c", "echo '" .. command .. "' | socat - " .. options.socket}

I have nc in OpenSUSE Tumbleweed, but don't have socat apparently. I'll give it a try sometime.

@Cananbolt
Copy link
Author

Thank you for looking into it!

@po5 po5 linked a pull request Oct 29, 2022 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants