Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Audit redesign spacing sizes and turn them into variables #934

Open
4 tasks
ericwbailey opened this issue Jul 12, 2020 · 7 comments · May be fixed by #1565
Open
4 tasks

Audit redesign spacing sizes and turn them into variables #934

ericwbailey opened this issue Jul 12, 2020 · 7 comments · May be fixed by #1565
Assignees
@kamariana
Labels
claimed Work is being done on an issue. good first issue A small, good place to get started working with the site. help wanted Issues the team would like assistince with. redesign styling Issues dealing with our Sass/CSS.

Comments

@ericwbailey
Copy link
Member

The redesign uses a lot of repetitive measurement declarations for distance sizing (1rem, 1.5rem, 2rem, etc.). We should:

  • Search through all margin and padding declarations,
  • See what declarations are commonly repeated and turn them into a set of Sass variables
  • Incorporate them into existing spacing utility classes
  • Identify outliers and see if they can be normalized
@ericwbailey ericwbailey added help wanted Issues the team would like assistince with. good first issue A small, good place to get started working with the site. redesign styling Issues dealing with our Sass/CSS. labels Jul 12, 2020
@kamariana
Copy link
Contributor

@ericwbailey, I can also work on this if you don't mind. Thanks

@ericwbailey
Copy link
Member Author

That would be amazing.

@ericwbailey ericwbailey added the claimed Work is being done on an issue. label Jul 29, 2020
@norfali
Copy link

norfali commented Mar 13, 2021

@Camariana @ericwbailey Is this issue still active? I'd be happy to help! :)

@ericwbailey
Copy link
Member Author

I'd defer to @Camariana, but I'd love the support, thanks!

@kamariana
Copy link
Contributor

Sure @norfali go ahead

@norfali
Copy link

norfali commented Mar 15, 2021

Awesome thanks, @Camariana!

@ericwbailey I will make a start sometime this week. 😃

@ErriGarcia
Copy link

Hi @ericwbailey is this issue still active? Me and my team would really like to help.

This was referenced Jun 19, 2023
Closed
Open
@davatron5000 davatron5000 linked a pull request Sep 3, 2023 that will close this issue
Issue#934 #1565
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kamariana kamariana

Labels
claimed Work is being done on an issue. good first issue A small, good place to get started working with the site. help wanted Issues the team would like assistince with. redesign styling Issues dealing with our Sass/CSS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue#934 ErriGarcia/a11yproject.com
4 participants
@ericwbailey @norfali @kamariana @ErriGarcia