Skip to content
This repository has been archived by the owner on Jul 18, 2022. It is now read-only.

Relying on process.execPath incorrectly detects vscode version #46

Open
dithpri opened this issue May 5, 2021 · 0 comments
Open

Relying on process.execPath incorrectly detects vscode version #46

dithpri opened this issue May 5, 2021 · 0 comments

Comments

@dithpri
Copy link

dithpri commented May 5, 2021

The extension checks if it runs in VSCode/VSCode insiders/VSCodium by checking the name of its binary. This is not a reliable way to detect the Code branding used.
For example, in my case, process.execPath is just /usr/lib/electron11/electron.
Furthermore, the editor is launched with /usr/bin/code, which is a symlink to /usr/bin/code-oss.

A better way would to check this would be to test vscode.env.appName for Code - OSS or VSCodium, etc..

Related: #42 #12

@dithpri dithpri changed the title Relying on the binary name incorrectly detects vscode version Relying on process.execPath name incorrectly detects vscode version May 5, 2021
@dithpri dithpri changed the title Relying on process.execPath name incorrectly detects vscode version Relying on process.execPath incorrectly detects vscode version May 5, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant