Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fill and stroke don't respect penWidth and overlap #486

Open
ademuri opened this issue Oct 6, 2024 · 2 comments
Open

Fill and stroke don't respect penWidth and overlap #486

ademuri opened this issue Oct 6, 2024 · 2 comments

Comments

@ademuri
Copy link
Contributor

ademuri commented Oct 6, 2024

When using both fill and stroke, they overlap:

image

I believe that they should instead be exclusive, taking into account the penWidth(s). In my example, the fill and stroke are different layers/strokes; this logic should take into account the width of both of those layers.

If you agree that this is a bug, I can look into this.

@abey79
Copy link
Owner

abey79 commented Nov 21, 2024

In principle I agree that this is a bug. In practice, I'm slightly worried about the artefacts around shapes that have very "pointy" features (think of a very narrow, but very high, triangle). The additional overlap around the periphery minimizes the coverage holes, as in this illustration:

image

@ademuri
Copy link
Contributor Author

ademuri commented Dec 2, 2024

Ah, that's a good point. What do you think about adding a parameter for changing the inset amount? I just saw a request for this feature in the drawingbots discord, and I think it would be useful.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants