Skip to content

Commit 0a2e114

Browse files
committed
Fix failing tests #1066
Signed-off-by: tdruez <tdruez@nexb.com>
1 parent d447438 commit 0a2e114

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

scanpipe/models.py

+10-4
Original file line numberDiff line numberDiff line change
@@ -3339,11 +3339,17 @@ def prefetch_for_serializer(self):
33393339
`DiscoveredDependencySerializer`.
33403340
Only the fields required by the serializer are fetched on the relations.
33413341
"""
3342-
manager = DiscoveredPackage.objects
33433342
return self.prefetch_related(
3344-
Prefetch("for_package", queryset=manager.only("package_uid")),
3345-
Prefetch("resolved_to_package", queryset=manager.only("package_uid")),
3346-
Prefetch("datafile_resource", queryset=manager.only("path")),
3343+
Prefetch(
3344+
"for_package", queryset=DiscoveredPackage.objects.only("package_uid")
3345+
),
3346+
Prefetch(
3347+
"resolved_to_package",
3348+
queryset=DiscoveredPackage.objects.only("package_uid"),
3349+
),
3350+
Prefetch(
3351+
"datafile_resource", queryset=CodebaseResource.objects.only("path")
3352+
),
33473353
)
33483354

33493355

scanpipe/tests/pipes/test_output.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,8 @@ def test_scanpipe_pipes_outputs_get_cyclonedx_bom_dependency_tree(self):
294294
make_dependency(project, for_package=a, resolved_to_package=b)
295295
make_dependency(project, for_package=b, resolved_to_package=c)
296296

297-
output_file = output.to_cyclonedx(project=project)
297+
with self.assertNumQueries(2):
298+
output_file = output.to_cyclonedx(project=project)
298299
results_json = json.loads(output_file.read_text())
299300

300301
expected = [
@@ -455,7 +456,7 @@ def test_scanpipe_pipes_outputs_to_attribution(self):
455456
package_data["notice_text"] = "Notice text"
456457
pipes.update_or_create_package(project, package_data)
457458

458-
with self.assertNumQueries(1):
459+
with self.assertNumQueries(2):
459460
output_file = output.to_attribution(project=project)
460461

461462
expected_file = self.data_path / "outputs" / "expected_attribution.html"

0 commit comments

Comments
 (0)