Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Issue #300: Attempt to address file system watching on Windows #301

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Issue #300: Attempt to address file system watching on Windows #301

wants to merge 6 commits into from

Conversation

brian-montgomery
Copy link
Contributor

Adding an environment variable (and wording) around getting hot reloads to work on Windows.

Fixes #300.

alexisreytech
alexisreytech reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@alexisreytech alexisreytech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-montgomery, thank you for working to address this issue of page reloading. I tested this by deleting the node modules folder and then using the make serve command with Docker. I added the new file to the astro directory, as described in the README file. However, I was only able to see the changes I made for testing purposes when I restarted the process again with make serve. It appears the page does not reload automatically to reflect new changes.

@brian-montgomery
Copy link
Contributor Author

@alexisreytech : If you get a chance, can you try this again?

@alexisreytech
Copy link
Contributor

@alexisreytech : If you get a chance, can you try this again?

@brian-montgomery, I tried testing this branch again, (I did make clean, make build, and make serve) and was unfortunately not able to see a difference. I tried making changes to a file and couldn't see the changes without manually reloading the page.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexisreytech alexisreytech alexisreytech left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address file polling on Windows
2 participants
@brian-montgomery @alexisreytech