Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

Clause template buttons overlap tooltips #185

Closed
Michael-Grover opened this issue Sep 2, 2020 · 9 comments · Fixed by #236
Closed

Clause template buttons overlap tooltips #185

Michael-Grover opened this issue Sep 2, 2020 · 9 comments · Fixed by #236
Assignees

Comments

@Michael-Grover
Copy link

Bug Report 🐛

Clause template buttons overlap tooltips so that the tooltips can't be read, like this example:
image

Expected Behavior

Tooltips should appear in front of everything else

@Manan17
Copy link

Manan17 commented Sep 15, 2020

It just needs a z-index = 1 in css file so that the tooltips can be read easily

@jolanglinais
Copy link
Member

@Manan17 yeah I think that makes sense. I believe a lot of other components in there use z-index, so it may need to be larger than 1.

@Manan17
Copy link

Manan17 commented Sep 15, 2020

Can I work on this issue?

@Michael-Grover
Copy link
Author

@Manan17 yes, thanks! I've assigned the issue to you.

@Manan17
Copy link

Manan17 commented Sep 15, 2020

I cannot see the clause template buttons in the live demo. Is it in the original code? So I have to run the app locally?

@Michael-Grover
Copy link
Author

Michael-Grover commented Sep 15, 2020

@Manan17 I recorded how to replicate the issue, let me know if this helps.

https://www.loom.com/share/fb5889cfc04a405f9a68c9212ea3f728

You have to go to the storybook https://ap-web-components.netlify.app/?path=/story/*
then select the contract editor
then choose the "Late Delivery and Penalty (with optional & this)" in the Knobs section

@Michael-Grover
Copy link
Author

in the video I chose the wrong template, but if you choose "Late Delivery and Penalty (with optional & this)" you will see the issue

image

@Manan17
Copy link

Manan17 commented Sep 15, 2020

Thanks. It helped me , starting to work on the issue

@K-Kumar-01
Copy link
Contributor

@Michael-Grover @irmerk
I have opened a PR for the issue as the issue seemed inactive to me.
Let me know if there are any changes required.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants