Feature/support resolve variable references #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
October 5, 2020 11:19
…for local references
…for lookup references
…for module references
…for variable references
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 63.78% 61.42% -2.37%
==========================================
Files 66 72 +6
Lines 1378 1602 +224
==========================================
+ Hits 879 984 +105
- Misses 419 532 +113
- Partials 80 86 +6
|
williepaul
reviewed
Oct 19, 2020
|
|
||
| // create output.ResourceConfig from hclConfigs.Resource | ||
| resourceConfig, err := CreateResourceConfig(managedResource) | ||
| if err != nil { | ||
| return allResourcesConfig, fmt.Errorf("failed to create ResourceConfig") | ||
| } | ||
|
|
||
| // resolve references |
There was a problem hiding this comment.
if a variable cannot be resolved, does this now cause an error? i think it would be preferable to continue processing while ignoring any missing vars.
| lookup := r.ResolveStrRef(table) | ||
|
|
||
| // check if lookup is a map | ||
| if reflect.TypeOf(lookup).String() != "map[string]interface {}" { |
There was a problem hiding this comment.
why not use a type assertion here like in the next if statement?
| case vType == "[]interface {}" && vKind == reflect.Slice: | ||
|
|
||
| // case 3: config value is a []interface{} | ||
| sConfig, ok := v.([]interface{}) |
There was a problem hiding this comment.
looks like a redundant check
williepaul
approved these changes
Oct 24, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.