From 2846a34258fdc0ddee456f6b92db2eafe44846aa Mon Sep 17 00:00:00 2001 From: Dave MacFarlane Date: Fri, 29 Oct 2021 14:57:18 -0400 Subject: [PATCH] [candidate_list] Remove meaningless Latest_Visit_Status column The max alphabetical visit doesn't mean anything. Resolves #5115, #7093 --- modules/candidate_list/jsx/candidateListIndex.js | 16 ---------------- .../php/candidatelistrowprovisioner.class.inc | 1 - modules/candidate_list/test/TestPlan.md | 1 - 3 files changed, 18 deletions(-) diff --git a/modules/candidate_list/jsx/candidateListIndex.js b/modules/candidate_list/jsx/candidateListIndex.js index b263c03e0bd..7ca644ed18a 100644 --- a/modules/candidate_list/jsx/candidateListIndex.js +++ b/modules/candidate_list/jsx/candidateListIndex.js @@ -306,22 +306,6 @@ class CandidateListIndex extends Component { }, }, }, - { - 'label': 'Latest Visit Status', - 'show': true, - 'filter': { - name: 'latestVisitStatus', - type: 'select', - hide: this.state.hideFilter, - options: { - 'Not Started': 'Not Started', - 'Screening': 'Screening', - 'Visit': 'Visit', - 'Approval': 'Approval', - 'Recycling Bin': 'Recycling Bin', - }, - }, - }, { 'label': 'Project', 'show': true, diff --git a/modules/candidate_list/php/candidatelistrowprovisioner.class.inc b/modules/candidate_list/php/candidatelistrowprovisioner.class.inc index 99c8c85b44b..9897ca5ff35 100644 --- a/modules/candidate_list/php/candidatelistrowprovisioner.class.inc +++ b/modules/candidate_list/php/candidatelistrowprovisioner.class.inc @@ -57,7 +57,6 @@ class CandidateListRowProvisioner extends \LORIS\Data\Provisioners\DBRowProvisio c.Sex, COUNT(DISTINCT s.Visit_label) AS VisitCount, IFNULL(MIN(feedback_bvl_thread.Status+0),0) AS Feedback, - max(s.Current_stage) AS LatestVisitStatus, p.Name AS RegistrationProject, c.RegistrationCenterID, c.RegistrationProjectID diff --git a/modules/candidate_list/test/TestPlan.md b/modules/candidate_list/test/TestPlan.md index 72b5f495e1d..9f8c7932445 100644 --- a/modules/candidate_list/test/TestPlan.md +++ b/modules/candidate_list/test/TestPlan.md @@ -18,7 +18,6 @@ [ ] Biological Sex [ ] Number of visits [ ] Date of birth - [ ] Latest Visit Status [ ] Feedback [Automation Testing] 9. Click "Clear Form" and ensure filters are reset to same state as #2.